Parameterize TypeSystem by its node kind

Parameterize TypeSystem by its node kind

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac39f0dd2b02bd76c3576cd57135b8d4e00c7392

[Johnni Winther, 2017-07-12 12:37:27]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-12 19:17:22]

lgtm

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_system.dart (right):

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_system.dart:591: PhiElementTypeInformation
allocatePhi(
should this return a Phi<T>?

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/types/...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/types/...
pkg/compiler/lib/src/types/types.dart:43: TypeMask typeOfNewList(Send node);
is your idea for these to also take a <T> in the future?

An alternative could be to introduce entities for these, but I actually like
your approach with the type parameter better.

[Siggi Cherem (dart-lang), 2017-07-12 19:17:49]

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_system.dart (right):

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_system.dart:591: PhiElementTypeInformation
allocatePhi(
On 2017/07/12 19:17:21, Siggi Cherem (dart-lang) wrote:
> should this return a Phi<T>?

(and same with the other APIs changed in this file)

[Johnni Winther, 2017-07-13 09:38:41]

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_system.dart (right):

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_system.dart:591: PhiElementTypeInformation
allocatePhi(
On 2017/07/12 19:17:21, Siggi Cherem (dart-lang) wrote:
> should this return a Phi<T>?

Yes. All references of PhiElementTypeInformation are now using <T>

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/types/...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2981613002/diff/1/pkg/compiler/lib/src/types/...
pkg/compiler/lib/src/types/types.dart:43: TypeMask typeOfNewList(Send node);
On 2017/07/12 19:17:21, Siggi Cherem (dart-lang) wrote:
> is your idea for these to also take a <T> in the future?
> 
> An alternative could be to introduce entities for these, but I actually like
> your approach with the type parameter better.

Don't know yet. Using T might lead to looking up type mask on arbitrary and
unrelated nodes, like we did with the AST. Maybe T plus assert in the
implementation like with TypeSystemStrategy.

[Johnni Winther, 2017-07-13 09:43:55]

Description was changed from

==========
Parameterize TypeSystem by its node kind
==========

to

==========
Parameterize TypeSystem by its node kind

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ac39f0dd2b02bd76c3576cd57135b8d4e00c7392
==========

[Johnni Winther, 2017-07-13 09:43:56]

Committed patchset #2 (id:20001) manually as
ac39f0dd2b02bd76c3576cd57135b8d4e00c7392 (presubmit successful).