Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: pkg/compiler/lib/src/inferrer/builder_kernel.dart

Issue 2981613002: Parameterize TypeSystem by its node kind (Closed)
Patch Set: Updated cf. comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/inferrer/builder_kernel.dart b/pkg/compiler/lib/src/inferrer/builder_kernel.dart
index 9be4f1a04f8af7267d4a42db72e78bbfbd250555..4eb9b3d4922d0ce42e0bc632f662a041f89c2083 100644
--- a/pkg/compiler/lib/src/inferrer/builder_kernel.dart
+++ b/pkg/compiler/lib/src/inferrer/builder_kernel.dart
@@ -30,7 +30,8 @@ class KernelTypeGraphBuilder extends ir.Visitor<TypeInformation> {
final MemberElement outermostElement;
final ir.Node analyzedNode;
final ResolvedAst resolvedAst;
- final TypeSystem types;
+ // TODO(johnniwinther): This should be TypeSystem<ir.Node>.
+ final TypeSystem<ast.Node> types;
LocalsHandler locals;
final InferrerEngine inferrer;
SideEffects sideEffects = new SideEffects.empty();
@@ -154,7 +155,7 @@ class KernelTypeGraphBuilder extends ir.Visitor<TypeInformation> {
for (ir.Expression element in listLiteral.expressions) {
TypeInformation type = element.accept(this);
elementType = elementType == null
- ? types.allocatePhi(null, null, type)
+ ? types.allocatePhi(null, null, type, isTry: false)
: types.addPhiInput(null, elementType, type);
length++;
}
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698