Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2981573002: [vm] Get a reference backtrace if we encounter disabled code when writing an AOT snapshot. (Closed)

Created:
3 years, 5 months ago by rmacnak
Modified:
3 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Get a reference backtrace if we encounter disabled code when writing an AOT snapshot. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/ba2deb77727621ca25c9d189be6922d1e2c86cec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
I forgot this tool got checked in :)
3 years, 5 months ago (2017-07-12 00:56:47 UTC) #2
regis
lgtm
3 years, 5 months ago (2017-07-12 01:08:05 UTC) #3
rmacnak
3 years, 5 months ago (2017-07-12 16:31:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba2deb77727621ca25c9d189be6922d1e2c86cec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698