Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: runtime/vm/clustered_snapshot.cc

Issue 2981573002: [vm] Get a reference backtrace if we encounter disabled code when writing an AOT snapshot. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/clustered_snapshot.cc
diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc
index a5346975c0b9972b38066db3c30421f50ddb3e45..29e64aa77857168d5e7bf118377de8a32b79d865 100644
--- a/runtime/vm/clustered_snapshot.cc
+++ b/runtime/vm/clustered_snapshot.cc
@@ -1599,9 +1599,9 @@ class CodeSerializationCluster : public SerializationCluster {
FATAL("Cannot serialize code with embedded pointers");
}
if (kind == Snapshot::kFullAOT) {
- // No disabled code in precompilation.
- NOT_IN_PRECOMPILED(ASSERT(code->ptr()->instructions_ ==
- code->ptr()->active_instructions_));
+ if (code->ptr()->instructions_ != code->ptr()->active_instructions_) {
+ s->UnexpectedObject(code, "Disabled code");
+ }
}
RawInstructions* instr = code->ptr()->instructions_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698