Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2981543002: Handle type variable test and typed list literal. (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +1 line, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 6 chunks +30 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-11 19:22:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2981543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2981543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode2388 pkg/compiler/lib/src/ssa/builder_kernel.dart:2388: ; delete
3 years, 5 months ago (2017-07-11 21:31:14 UTC) #3
Johnni Winther
https://codereview.chromium.org/2981543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2981543002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode2388 pkg/compiler/lib/src/ssa/builder_kernel.dart:2388: ; On 2017/07/11 21:31:14, Siggi Cherem (dart-lang) wrote: > ...
3 years, 5 months ago (2017-07-13 08:58:18 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-13 09:05:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f644cffa3384cb05da81292ed57737697fd7ae5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698