Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pkg/compiler/lib/src/ssa/type_builder.dart

Issue 2981543002: Handle type variable test and typed list literal. (Closed)
Patch Set: Updated cf. comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/type_builder.dart
diff --git a/pkg/compiler/lib/src/ssa/type_builder.dart b/pkg/compiler/lib/src/ssa/type_builder.dart
index e7b06c9a6960a099e6a14527fbc5d3e0fc313b36..20db7ab53def0c971299d14405f32d167c406fea 100644
--- a/pkg/compiler/lib/src/ssa/type_builder.dart
+++ b/pkg/compiler/lib/src/ssa/type_builder.dart
@@ -16,7 +16,7 @@ import '../universe/use.dart' show TypeUse;
/// Functions to insert type checking, coercion, and instruction insertion
/// depending on the environment for dart code.
-abstract class TypeBuilder {
+class TypeBuilder {
final GraphBuilder builder;
TypeBuilder(this.builder);
@@ -143,8 +143,6 @@ abstract class TypeBuilder {
return builder.pop();
}
- InterfaceType getThisType(ClassEntity cls);
-
HInstruction buildTypeArgumentRepresentations(
DartType type, MemberEntity sourceElement) {
assert(!type.isTypeVariable);
@@ -158,7 +156,7 @@ abstract class TypeBuilder {
}
HInstruction representation = new HTypeInfoExpression(
TypeInfoExpressionKind.INSTANCE,
- getThisType(interface.element),
+ builder.closedWorld.elementEnvironment.getThisType(interface.element),
inputs,
builder.commonMasks.dynamicType);
return representation;
« no previous file with comments | « pkg/compiler/lib/src/ssa/optimize.dart ('k') | tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698