Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2981443002: Revert of Fixed some nits based on reviewer comments. (Closed)

Created:
3 years, 5 months ago by Sébastien Marchand
Modified:
3 years, 5 months ago
Reviewers:
njanevsk, etienneb
CC:
syzygy-changes_googlegroups.com, chrisha
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Revert of Fixed some nits based on reviewer comments. (patchset #1 id:1 of https://codereview.chromium.org/2974783002/ ) Reason for revert: Please don't commit until you've addressed all the comments. Original issue's description: > Fixed some nits based on reviewer comments here: > https://codereview.chromium.org/2977433002/ > and here: > https://codereview.chromium.org/2946063002/ > > BUG= > > Review-Url: https://codereview.chromium.org/2974783002 > Committed: https://github.com/google/syzygy/commit/ca5c6ffffaa76f7348be08dab6ba21bcadcc5a0d TBR=etienneb@chromium.org,njanevsk@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2981443002 Committed: https://github.com/google/syzygy/commit/645f2dfea673cb5051a9cc73a2870036e3afe1e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M syzygy/integration_tests/make_integration_tests_clang.py View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sébastien Marchand
Created Revert of Fixed some nits based on reviewer comments.
3 years, 5 months ago (2017-07-10 18:23:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981443002/1
3 years, 5 months ago (2017-07-10 18:23:42 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 18:23:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/google/syzygy/commit/645f2dfea673cb5051a9cc73a2870036e3afe1e0

Powered by Google App Engine
This is Rietveld 408576698