Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap

Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap

- and to KernelToElementMapForImpact
+ Remove CapturedScopeBuilder._kernelToElementMap
+ Remove JLocalFunction

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/6292f410d12b40d5f5690ea4995d2b0726db11cc

[Johnni Winther, 2017-07-21 15:08:27]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-07-21 22:21:44]

lgtm

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (left):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:486: ?
compiler.resolution.commonElements.boundClosureClass
This was the behavior in the old code. Why is it no longer necessary?

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (left):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:390: ?
commonElements.boundClosureClass
ditto

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1073: Local
_getLocalFunction(ir.TreeNode node) {
I know you've done this elsewhere, but why the public and private versions of
this method when they are identical?

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:380: void registerClosureClass(covariant
ClassEntity cls);
then we can cut the covariant keyword and just have "ClassEntity" on the Kernel
side

[Johnni Winther, 2017-07-28 12:08:19]

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (left):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:486: ?
compiler.resolution.commonElements.boundClosureClass
On 2017/07/21 22:21:43, Emily Fortuna wrote:
> This was the behavior in the old code. Why is it no longer necessary?

This is what happens when the types are not precise enough: Originally the type
of [methodElement] was `FunctionElement` which includes both `MethodElement`
(which can be an instance member) and `LocalFunctionElement` (which can't). When
I improved the type precision of `closure.dart` to always use
[LocalFunctionElement] I didn't notice this line. We have _never_ created a
closure class for a tear-off but the types indicated that we did.

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (left):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:390: ?
commonElements.boundClosureClass
On 2017/07/21 22:21:43, Emily Fortuna wrote:
> ditto

ditto :)

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1073: Local
_getLocalFunction(ir.TreeNode node) {
On 2017/07/21 22:21:43, Emily Fortuna wrote:
> I know you've done this elsewhere, but why the public and private versions of
> this method when they are identical?

Not needed here (now remove). I other places it was needed to add additional
arguments to the implementation method or restricting the type in ways not
allowed by strong mode.

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2981423003/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:380: void registerClosureClass(covariant
ClassEntity cls);
On 2017/07/21 22:21:43, Emily Fortuna wrote:
> then we can cut the covariant keyword and just have "ClassEntity" on the
Kernel
> side

Done.

[Johnni Winther, 2017-07-28 12:13:35]

Description was changed from

==========
Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap

- and to KernelToElementMapForImpact
+ Remove CapturedScopeBuilder._kernelToElementMap
+ Remove JLocalFunction
==========

to

==========
Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap

- and to KernelToElementMapForImpact
+ Remove CapturedScopeBuilder._kernelToElementMap
+ Remove JLocalFunction

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6292f410d12b40d5f5690ea4995d2b0726db11cc
==========

[Johnni Winther, 2017-07-28 12:13:36]

Committed patchset #2 (id:20001) manually as
6292f410d12b40d5f5690ea4995d2b0726db11cc (presubmit successful).