Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2981423003: Move .getLocalFunction from KernelToElementMap to KernelToLocalsMap (Closed)
Patch Set: Updated cf. comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure_visitors.dart ('k') | pkg/compiler/lib/src/js_model/js_strategy.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_model/elements.dart
diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart
index 1d02a1aa45a59a113f88bc04250c3e86298b259e..6ed79c20dfc0967ba4141330914e1144d62fdbca 100644
--- a/pkg/compiler/lib/src/js_model/elements.dart
+++ b/pkg/compiler/lib/src/js_model/elements.dart
@@ -172,15 +172,6 @@ class JsElementCreatorMixin {
isStatic: isStatic, isAssignable: isAssignable, isConst: isConst);
}
- Local createLocalFunction(String name, MemberEntity memberContext,
- Entity executableContext, FunctionType functionType) {
- // TODO(efortuna, johnniwinther): This function should not be called once
- // the K + J element situation has been properly sorted out. Ultimately this
- // should throw.
- return new JLocalFunction(
- name, memberContext, executableContext, functionType);
- }
-
LibraryEntity convertLibrary(IndexedLibrary library) {
return createLibrary(
library.libraryIndex, library.name, library.canonicalUri);
@@ -547,16 +538,3 @@ class JTypeVariable implements TypeVariableEntity, IndexedTypeVariable {
String toString() =>
'${jsElementPrefix}type_variable(${typeDeclaration.name}.$name)';
}
-
-class JLocalFunction implements Local {
- final String name;
- final MemberEntity memberContext;
- final Entity executableContext;
- final FunctionType functionType;
-
- JLocalFunction(
- this.name, this.memberContext, this.executableContext, this.functionType);
-
- String toString() => '${jsElementPrefix}local_function'
- '(${memberContext.name}.${name ?? '<anonymous>'})';
-}
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure_visitors.dart ('k') | pkg/compiler/lib/src/js_model/js_strategy.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698