Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2981403002: Add dart2js_with_kernel_in_ssa flag to test.dart and pass it along to dart2js (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

We'll be using dart2js_with_kernel for a more general purpose, but need dart2js_with_kernel_in_ssa while we transition over. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/985dee0f5ba381a5d83d75b21f5f6538d7a70cb3

Patch Set 1 #

Patch Set 2 : Changed flag name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/testing/dart/configuration.dart View 1 3 chunks +3 lines, -0 lines 0 comments Download
M tools/testing/dart/environment.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/testing/dart/options.dart View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-20 18:37:48 UTC) #1
Siggi Cherem (dart-lang)
friendly ping :)
3 years, 5 months ago (2017-07-21 15:15:22 UTC) #2
Siggi Cherem (dart-lang)
PTAL - as discussed I renamed the flag to make it more dart2js specific. I ...
3 years, 5 months ago (2017-07-21 23:20:15 UTC) #4
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-24 19:43:50 UTC) #6
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-24 20:07:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
985dee0f5ba381a5d83d75b21f5f6538d7a70cb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698