Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2981273003: Revert of Handle Java assert using a customized function in base (Closed)

Created:
3 years, 5 months ago by mgersh
Modified:
3 years, 5 months ago
Reviewers:
F, Ran, Yaron, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, danakj+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Handle Java assert using a customized function in base (patchset #8 id:390001 of https://codereview.chromium.org/2971063003/ ) Reason for revert: Broke compile on Cronet bots with error about "can't find referenced class org.chromium.base.JavaExceptionReporter": https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61854 Original issue's description: > Create java_assertion_handler, a Java binary that takes in a JAR file > and modifies the bytecode of classes. > > Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler > that throws Exception. > > Output is written to a new JAR file. > > > BUG=672945 > > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Commit-Position: refs/heads/master@{#487903} > Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589 TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672945 Review-Url: https://codereview.chromium.org/2981273003 Cr-Commit-Position: refs/heads/master@{#487914} Committed: https://chromium.googlesource.com/chromium/src/+/14d4eb4fdc5322d951fc70972d18d507bd5abe59

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
mgersh
Created Revert of Handle Java assert using a customized function in base
3 years, 5 months ago (2017-07-19 18:07:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981273003/1
3 years, 5 months ago (2017-07-19 18:07:23 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 18:08:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14d4eb4fdc5322d951fc70972d18...

Powered by Google App Engine
This is Rietveld 408576698