The CQ bit was checked by mgersh@chromium.org
Created Revert of Handle Java assert using a customized function in base
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1500487625122300, "parent_rev": "c6e56f943673a2b277544e7b07f037121bfdc561", "commit_rev": "14d4eb4fdc5322d951fc70972d18d507bd5abe59"}
Description was changed from ========== Revert of Handle Java assert using a customized function in base (patchset #8 id:390001 of https://codereview.chromium.org/2971063003/ ) Reason for revert: Broke compile on Cronet bots with error about "can't find referenced class org.chromium.base.JavaExceptionReporter": https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86... Original issue's description: > Create java_assertion_handler, a Java binary that takes in a JAR file > and modifies the bytecode of classes. > > Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler > that throws Exception. > > Output is written to a new JAR file. > > > BUG=672945 > > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Commit-Position: refs/heads/master@{#487903} > Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d... TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chrom... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672945 ========== to ========== Revert of Handle Java assert using a customized function in base (patchset #8 id:390001 of https://codereview.chromium.org/2971063003/ ) Reason for revert: Broke compile on Cronet bots with error about "can't find referenced class org.chromium.base.JavaExceptionReporter": https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86... Original issue's description: > Create java_assertion_handler, a Java binary that takes in a JAR file > and modifies the bytecode of classes. > > Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler > that throws Exception. > > Output is written to a new JAR file. > > > BUG=672945 > > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Commit-Position: refs/heads/master@{#487903} > Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d... TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chrom... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672945 Review-Url: https://codereview.chromium.org/2981273003 Cr-Commit-Position: refs/heads/master@{#487914} Committed: https://chromium.googlesource.com/chromium/src/+/14d4eb4fdc5322d951fc70972d18... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14d4eb4fdc5322d951fc70972d18...