Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2981263002:
gitiles: add Refs API. (Closed)
|
Created:
3 years, 5 months ago by tandrii(chromium) Modified:
3 years, 5 months ago Reviewers:
Vadim Sh. CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
Descriptiongitiles: add Refs API.
With docs, including best practice recommendation, and tests.
BUG=646067
Review-Url: https://codereview.chromium.org/2981263002
Committed: https://github.com/luci/luci-go/commit/40d91be436113be187ee76988a793712076c06bb
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : nits #Patch Set 5 : rebase #
Total comments: 4
Patch Set 6 : rebase #Patch Set 7 : review #
Depends on Patchset: Messages
Total messages: 42 (36 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== gitiles: add Refs API. BUG=646067 ========== to ========== gitiles: add Refs API. With docs, including best practice recommendation, and tests. BUG=646067 ==========
tandrii@chromium.org changed reviewers: + vadimsh@chromium.org
ptal
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... File common/api/gitiles/gitiles.go (right): https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... common/api/gitiles/gitiles.go:170: // refsPath limits whcih refs to resolve to only those matching {refsPath}/*. which https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... common/api/gitiles/gitiles.go:194: if !strings.HasPrefix(refsPath, "refs") { refsPath != "refs" && !strings.HasPrefix(refsPath, "refs/")
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/377aa92fb8863710) Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/377aa930000cc210) Luci-go Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/377aa92fa8ebfb10)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... File common/api/gitiles/gitiles.go (right): https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... common/api/gitiles/gitiles.go:170: // refsPath limits whcih refs to resolve to only those matching {refsPath}/*. On 2017/07/20 21:09:09, Vadim Sh. wrote: > which Done. https://codereview.chromium.org/2981263002/diff/80001/common/api/gitiles/giti... common/api/gitiles/gitiles.go:194: if !strings.HasPrefix(refsPath, "refs") { On 2017/07/20 21:09:09, Vadim Sh. wrote: > refsPath != "refs" && !strings.HasPrefix(refsPath, "refs/") Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org Link to the patchset: https://codereview.chromium.org/2981263002/#ps120001 (title: "review")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2983513002 Patch 220001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500627194938480,
"parent_rev": "c4abe79ec19a51f9bcb02e4aaaee09f9325a3cbf", "commit_rev":
"40d91be436113be187ee76988a793712076c06bb"}
Message was sent while issue was closed.
Description was changed from ========== gitiles: add Refs API. With docs, including best practice recommendation, and tests. BUG=646067 ========== to ========== gitiles: add Refs API. With docs, including best practice recommendation, and tests. BUG=646067 Review-Url: https://codereview.chromium.org/2981263002 Committed: https://github.com/luci/luci-go/commit/40d91be436113be187ee76988a793712076c06bb ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://github.com/luci/luci-go/commit/40d91be436113be187ee76988a793712076c06bb |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
