Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2981033002: Fix copyright header presubmit (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M PRESUBMIT.py View 3 chunks +37 lines, -14 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
iannucci
3 years, 5 months ago (2017-07-15 01:06:22 UTC) #1
Ryan Tseng
https://codereview.chromium.org/2981033002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2981033002/diff/1/PRESUBMIT.py#newcode109 PRESUBMIT.py:109: lines[0] = lines[0].replace('YEARPATTERN', years_re) lol
3 years, 5 months ago (2017-07-15 01:08:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981033002/1
3 years, 5 months ago (2017-07-15 01:09:20 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-15 01:09:21 UTC) #10
Ryan Tseng
lgtm
3 years, 5 months ago (2017-07-15 01:11:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981033002/1
3 years, 5 months ago (2017-07-15 01:11:41 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-15 01:15:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/2cc44f95c0979db5c36032ec9685695af421c3c5

Powered by Google App Engine
This is Rietveld 408576698