Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2981023002: Move Win32 API Histogram code to AXPlatformNode so that it can be shared. (Closed)

Created:
3 years, 5 months ago by dougt
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Win32 API Histogram code to AXPlatformNode so that it can be shared. One side effect of this is that we will begin collecting data on API usage from views (on the APIs we've migrated to platform node). BUG=703369 Review-Url: https://codereview.chromium.org/2981023002 Cr-Commit-Position: refs/heads/master@{#487123} Committed: https://chromium.googlesource.com/chromium/src/+/05e325468af27dfd72e5090bd94276b14ce2beb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -241 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.cc View 65 chunks +0 lines, -241 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.h View 1 chunk +172 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 35 chunks +39 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
dougt
alice, can you take a look?
3 years, 5 months ago (2017-07-15 02:11:20 UTC) #6
dougt
dmazzoni, ptal.
3 years, 5 months ago (2017-07-17 14:45:02 UTC) #8
dmazzoni
lgtm Ah, this is the change I was missing! :)
3 years, 5 months ago (2017-07-17 15:37:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981023002/1
3 years, 5 months ago (2017-07-17 15:46:17 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 16:59:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05e325468af27dfd72e5090bd942...

Powered by Google App Engine
This is Rietveld 408576698