Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2980983002: Use dummy class to locate NSBundle. (Closed)

Created:
3 years, 5 months ago by jzw1
Modified:
3 years, 5 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use dummy class to locate NSBundle. This is the safest way to avoid potential dead lock issues with dispatch_once and ios_web_view::InitializeGlobalState(). BUG= Review-Url: https://codereview.chromium.org/2980983002 Cr-Commit-Position: refs/heads/master@{#486867} Committed: https://chromium.googlesource.com/chromium/src/+/fcc9f6614289d1e710fb49bd4e116fbdc08cb966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ios/web_view/internal/web_view_web_main_delegate.mm View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jzw1
On 2017/07/14 19:31:10, jzw1 wrote: > mailto:jzw@chromium.org changed reviewers: > + mailto:eugenebut@chromium.org, mailto:ichikawa@chromium.org, mailto:michaeldo@chromium.org PTAL ...
3 years, 5 months ago (2017-07-14 19:31:40 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 5 months ago (2017-07-14 19:53:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980983002/1
3 years, 5 months ago (2017-07-14 20:08:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fcc9f6614289d1e710fb49bd4e116fbdc08cb966
3 years, 5 months ago (2017-07-14 20:23:49 UTC) #9
michaeldo
3 years, 5 months ago (2017-07-14 21:28:56 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698