config_service: Fixed multiple ajax requests in the front page while the page determines whether a …

config_service: Fixed multiple ajax requests in the front page while the page determines whether a user is signed in.

This CL disables the auto ajax requests and is instead triggered by the loading of the google auth API and user
object.

BUG=742522
Review-Url: https://codereview.chromium.org/2980973002
Committed: https://github.com/luci/luci-py/commit/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6

[cwpayton, 2017-07-14 18:12:08]

cwpayton@google.com changed reviewers:
+ hinoka@chromium.org, sergeyberezin@chromium.org

[cwpayton, 2017-07-14 18:12:09]

PTAL.

Link to staging version can be found here:
https://2965-dc53549-tainted-cwpayton-dot-luci-config.appspot.com/newui

[cwpayton, 2017-07-14 18:19:42]

Description was changed from

==========
config_service: Fixed multiple ajax requests in the front page while the page
determines whether a user is signed in.

This CL disables the auto ajax requests and is instead triggered by the loading
of the google auth API and user
object.

BUG=742552
==========

to

==========
config_service: Fixed multiple ajax requests in the front page while the page
determines whether a user is signed in.

This CL disables the auto ajax requests and is instead triggered by the loading
of the google auth API and user
object.

BUG=742522
==========

[Ryan Tseng, 2017-07-14 18:52:29]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-07-14 18:52:30]

https://codereview.chromium.org/2980973002/diff/20001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/front-page.html (right):

https://codereview.chromium.org/2980973002/diff/20001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/front-page.html:129:
window.setTimeout(function() {
Can we bind to and event where the auth_header being set instead?  Timers are
usually only used as a last resort.

[cwpayton, 2017-07-14 20:05:58]

PTAL.

Staging version is still up here:
https://2965-dc53549-tainted-cwpayton-dot-luci-config.appspot.com/newui

[Ryan Tseng, 2017-07-14 20:43:05]

https://codereview.chromium.org/2980973002/diff/60001/appengine/config_servic...
File appengine/config_service/ui/common/auth-signin.html (right):

https://codereview.chromium.org/2980973002/diff/60001/appengine/config_servic...
appengine/config_service/ui/common/auth-signin.html:122:
window.setTimeout(function(){
Actually you just have to attach this function to the google-signin-aware's
initialized-changed event, export a new "ready" event from this component,
remove the exported user property, and you can remove all of the timers here and
simplify the code in the other modules.

[cwpayton, 2017-07-17 17:12:13]

PTAL. Link to new staging version can be found here:
https://2967-4366b3c-tainted-cwpayton-dot-luci-config.appspot.com/newui

[Sergey Berezin, 2017-07-18 00:17:58]

LGTM, thanks! I'd also wait for Ryan before landing, since he had some comments.

[cwpayton, 2017-07-18 18:39:01]

PTAL. Link to staging version still exists here:
https://2967-4366b3c-tainted-cwpayton-dot-luci-config.appspot.com/newui

[cwpayton, 2017-07-18 21:35:48]

The CQ bit was checked by cwpayton@google.com

[cwpayton, 2017-07-18 21:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/2980973002/#ps120001
(title: "Cleaned up unnecessary code")

[commit-bot: I haz the power, 2017-07-18 21:36:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-18 21:38:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500413748484960,
"parent_rev": "3eb44d2179038db9f1cb33fd852f4918e9fe2b2c", "commit_rev":
"bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6"}

[commit-bot: I haz the power, 2017-07-18 21:38:15]

Description was changed from

==========
config_service: Fixed multiple ajax requests in the front page while the page
determines whether a user is signed in.

This CL disables the auto ajax requests and is instead triggered by the loading
of the google auth API and user
object.

BUG=742522
==========

to

==========
config_service: Fixed multiple ajax requests in the front page while the page
determines whether a user is signed in.

This CL disables the auto ajax requests and is instead triggered by the loading
of the google auth API and user
object.

BUG=742522

Review-Url: https://codereview.chromium.org/2980973002
Committed:
https://github.com/luci/luci-py/commit/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6
==========

[commit-bot: I haz the power, 2017-07-18 21:38:16]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-py/commit/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6