Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 2980853002: Registration-based approach to cross frame support. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart b/pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart
index 248f8aab63f82d426dd314f8ed25cfff534d3f1a..1bc325ec43bf32d0afd50cb4fe9bdad2d06761b3 100644
--- a/pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart
+++ b/pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart
@@ -76,6 +76,9 @@ import 'dart:_interceptors'
export 'dart:math' show Rectangle, Point;
+// TODO(vsm): Remove this.
Jennifer Messerly 2017/07/14 19:38:08 interesting! is the goal to rely on a common libra
vsm 2017/07/19 15:59:01 Yes, we're sharing dart:html with dart2js, so I do
+import 'dart:_runtime' as dart;
+
/**
* Top-level container for a web page, which is usually a browser tab or window.
*
@@ -45860,6 +45863,8 @@ class _DOMWindowCrossFrame implements WindowBase {
return w;
} else {
// TODO(vsm): Cache or implement equality.
vsm 2017/07/13 15:31:33 Caching needs to be fixed before this is landed.
vsm 2017/07/14 15:36:15 I'll do / land this in a separate CL as this code
+ dart.polyfill(w);
+ dart.applyAllExtensions(w);
return new _DOMWindowCrossFrame(w);
}
}

Powered by Google App Engine
This is Rietveld 408576698