Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1979)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2980853002: Registration-based approach to cross frame support. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart » ('j') | pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index 0151900afd6df6da23c1411172288eb7f688fbbf..e5f90628b5d1451425bf60f7b6d317055b05259a 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -1786,11 +1786,8 @@ class CodeGenerator extends Object
void _registerExtensionType(
ClassElement classElem, String jsPeerName, List<JS.Statement> body) {
if (jsPeerName != null) {
- body.add(_callHelperStatement('registerExtension(#.global.#, #);', [
- _runtimeModule,
- _propertyName(jsPeerName),
- _emitTopLevelName(classElem)
- ]));
+ body.add(_callHelperStatement('registerExtension(#, #);',
Jennifer Messerly 2017/07/14 19:38:08 oh wow, this is much cleaner :)
+ [js.string(jsPeerName), _emitTopLevelName(classElem)]));
}
}
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart » ('j') | pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698