Registration-based approach to cross frame support.

Registration-based approach to cross frame support.

This approach installs all Dart extension types onto a window whenever
that window is accessed.

See #28326

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/99e672d1cb5db4cf0568303784b150b4480a632a

[vsm, 2017-07-13 15:31:33]

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart:45862: //
TODO(vsm): Cache or implement equality.
Caching needs to be fixed before this is landed.  Otherwise, we'll install
everytime.

[vsm, 2017-07-14 15:36:15]

vsm@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[vsm, 2017-07-14 15:36:16]

Note - alternative approach here:

https://codereview.chromium.org/2982723002/

That one is more like dart2js, but I think this is more solid going forward.

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart:45862: //
TODO(vsm): Cache or implement equality.
On 2017/07/13 15:31:33, vsm wrote:
> Caching needs to be fixed before this is landed.  Otherwise, we'll install
> everytime.

I'll do / land this in a separate CL as this code is used by dart2js as well.

[Jacob, 2017-07-14 15:44:11]

I like this approach.

[Jennifer Messerly, 2017-07-14 19:38:08]

Wow this looks great!

Requesting one change to code for JSArray that should be obsolete (it looks like
a merge conflict) ... otherwise LGTM

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1789:
body.add(_callHelperStatement('registerExtension(#, #);',
oh wow, this is much cleaner :)

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart:79: +//
TODO(vsm): Remove this.
interesting! is the goal to rely on a common library that dart2js also supports?
I guess I'm not clear on what the TODO is about?

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:414: // is
JSArray, which we rewire to the native Array type.
hmmm wait I don't understand the JSArray comment. JSArray also bottoms out at
core.Object. I fixed that in my CL. Maybe try reverting this change? it should
be a no-op now.

That's why we walk up the class hierarchy:
* start from the ES6 class for JSArray
* walk up its __proto__
* that takes you to the ES6 class for core.Object

... the problem that happened before is:
* start from the ES6 class JSArray
* get `JSArray.prototype`
* walk up its __proto__
* that takes you to JavaScript's `Array.prototype`
* walk up its __proto__
* that takes you to JavaScript's `Object.prototype`

... anyways, if revert doesn't work, LMK, I can try and debug what's going on?

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:443: var
_extensionMap;
this can be eager initialized:

    final _extensionMap = JS('', 'new Map()');

we'll always have extension types, Dart can't run without
numbers/strings/bools/arrays/etc :)

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:456: let
extProto = $dartExtType.prototype;
this line is unused. I'm guessing it was a merge conflict with my change that
fixed JSArray

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:492:
_cacheExtension(name, dartExtType);
based on suggestion above this is a 1-liner now and can be inlined:

    registerExtension(name, dartExtType) {
      JS('', '#.set(#, #)', _extensionMap, name, dartExtType);
      ...

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart:88:
window.SourceBufferList = new window.MediaSource().sourceBuffers.constructor;
long line

[vsm, 2017-07-14 20:22:25]

Thanks!

Jen -

Re dart:html - I want to avoid forking dart:html.  It already imports
dart:_js_helper (where we have a specific ddc version), so I'll move the hook
there and add a no-op one for dart2js.  I'll do that separately.

Re Array - I started this before your CL.  I'll try again now without.

[vsm, 2017-07-19 15:59:02]

PTAL

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart:79: +//
TODO(vsm): Remove this.
On 2017/07/14 19:38:08, Jennifer Messerly wrote:
> interesting! is the goal to rely on a common library that dart2js also
supports?
> I guess I'm not clear on what the TODO is about?

Yes, we're sharing dart:html with dart2js, so I don't want to fork.

Added a hook in a since submitted CL to move this logic to js_helper - where
we've already got a custom version.  The hook is still invoked here when we
create a WindowCrossFrame.

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:443: var
_extensionMap;
On 2017/07/14 19:38:08, Jennifer Messerly wrote:
> this can be eager initialized:
> 
>     final _extensionMap = JS('', 'new Map()');
> 
> we'll always have extension types, Dart can't run without
> numbers/strings/bools/arrays/etc :)

Done.

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:456: let
extProto = $dartExtType.prototype;
On 2017/07/14 19:38:08, Jennifer Messerly wrote:
> this line is unused. I'm guessing it was a merge conflict with my change that
> fixed JSArray

Done.

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:492:
_cacheExtension(name, dartExtType);
On 2017/07/14 19:38:08, Jennifer Messerly wrote:
> based on suggestion above this is a 1-liner now and can be inlined:
> 
>     registerExtension(name, dartExtType) {
>       JS('', '#.set(#, #)', _extensionMap, name, dartExtType);
>       ...

Done.

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart (right):

https://codereview.chromium.org/2980853002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart:88:
window.SourceBufferList = new window.MediaSource().sourceBuffers.constructor;
On 2017/07/14 19:38:08, Jennifer Messerly wrote:
> long line

Done.

https://codereview.chromium.org/2980853002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/2980853002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart:67: +       
registerGlobalObject;
Note, this is just a direct copy now of the dart2js version of this file. 
Forgot to copy over in my last CL (where I added the hook).

[Jennifer Messerly, 2017-07-19 19:11:04]

lgtm++

[vsm, 2017-07-19 19:53:55]

Description was changed from

==========
Registration-based approach to cross frame support.

This approach installs all Dart extension types onto a window whenever
that window is accessed.

See #28326
==========

to

==========
Registration-based approach to cross frame support.

This approach installs all Dart extension types onto a window whenever
that window is accessed.

See #28326

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/99e672d1cb5db4cf0568303784b150b4480a632a
==========

[vsm, 2017-07-19 19:53:57]

Committed patchset #3 (id:20001) manually as
99e672d1cb5db4cf0568303784b150b4480a632a (presubmit successful).