Issue 2980813002: Pass backend Target into Kernel driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980813002: Pass backend Target into Kernel driver. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Pass backend Target into Kernel driver. Mock SDK in analyzer does not include all the internal libraries that VM requires, and probably does not have to for analysis. So, we might use NoneTarget to avoid requiring extra libraries and transformations. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bead5672c6816ed8a76550054335610c2f68454a

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -14 lines)			Patch
M	pkg/front_end/lib/src/incremental/kernel_driver.dart	View	5 chunks	+7 lines, -10 lines	0 comments	Download
M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/front_end/test/src/incremental/kernel_driver_test.dart	View	2 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 5 months ago (2017-07-13 16:13:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bead5672c6816ed8a76550054335610c2f68454a (presubmit successful).