Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: pkg/front_end/lib/src/incremental/kernel_driver.dart

Issue 2980813002: Pass backend Target into Kernel driver. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/incremental_kernel_generator_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/incremental/kernel_driver.dart
diff --git a/pkg/front_end/lib/src/incremental/kernel_driver.dart b/pkg/front_end/lib/src/incremental/kernel_driver.dart
index 2fef1e0b37b9519b392e8475b30b7d46fca6ec74..0216cc7d6e9e09a0e53ae301ce70eee1a427f5f4 100644
--- a/pkg/front_end/lib/src/incremental/kernel_driver.dart
+++ b/pkg/front_end/lib/src/incremental/kernel_driver.dart
@@ -17,8 +17,7 @@ import 'package:front_end/src/incremental/byte_store.dart';
import 'package:front_end/src/incremental/file_state.dart';
import 'package:kernel/binary/ast_from_binary.dart';
import 'package:kernel/kernel.dart' hide Source;
-import 'package:kernel/target/targets.dart' show TargetFlags;
-import 'package:kernel/target/vm_fasta.dart' show VmFastaTarget;
+import 'package:kernel/target/targets.dart' show Target;
import 'package:meta/meta.dart';
/// This function is invoked for each newly discovered file, and the returned
@@ -57,8 +56,8 @@ class KernelDriver {
/// The object that knows how to resolve "package:" and "dart:" URIs.
final UriTranslator _uriTranslator;
- /// Is `true` if strong mode analysis should be used.
- final bool _strongMode;
+ /// The backend target to generate kernels for.
+ final Target _target;
/// The function that is invoked when a new file is about to be added to
/// the current file state. The [Future] that it returns is awaited before
@@ -79,7 +78,7 @@ class KernelDriver {
final _TestView _testView = new _TestView();
KernelDriver(this._logger, this._fileSystem, this._byteStore,
- this._uriTranslator, this._strongMode,
+ this._uriTranslator, this._target,
{KernelDriverFileAddedFn fileAddedFn})
: _fileAddedFn = fileAddedFn {
_computeSalt();
@@ -130,10 +129,8 @@ class KernelDriver {
});
CanonicalName nameRoot = new CanonicalName.root();
- DillTarget dillTarget = new DillTarget(
- new Ticker(isVerbose: false),
- _uriTranslator,
- new VmFastaTarget(new TargetFlags(strongMode: _strongMode)));
+ DillTarget dillTarget =
+ new DillTarget(new Ticker(isVerbose: false), _uriTranslator, _target);
List<LibraryCycleResult> results = [];
_testView.compiledCycles.clear();
@@ -283,7 +280,7 @@ class KernelDriver {
void _computeSalt() {
var saltBuilder = new ApiSignature();
saltBuilder.addInt(DATA_VERSION);
- saltBuilder.addBool(_strongMode);
+ saltBuilder.addBool(_target.strongMode);
_salt = saltBuilder.toByteList();
}
« no previous file with comments | « no previous file | pkg/front_end/lib/src/incremental_kernel_generator_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698