V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2980793002
Cr-Commit-Position: refs/heads/master@{#494022}
Committed: https://chromium.googlesource.com/chromium/src/+/1bcbdbe7292b842776463402c1b5e6db83bafb77

[mojahsu1, 2017-07-13 03:38:11]

Description was changed from

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
==========

to

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mojahsu1, 2017-07-13 04:08:16]

Description was changed from

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mojahsu1, 2017-07-13 04:08:16]

mojahsu@chromium.org changed reviewers:
+ henryhsu@chromium.org, wuchengli@chromium.org

[wuchengli, 2017-07-18 05:59:01]

lgtm. Please merger after https://chromium-review.googlesource.com/c/566742 is
merged.

[wuchengli, 2017-07-18 06:02:15]

wuchengli@chromium.org changed reviewers:
- henryhsu@chromium.org

[mojahsu1, 2017-08-14 07:23:14]

The CQ bit was checked by mojahsu@chromium.org

[commit-bot: I haz the power, 2017-08-14 07:23:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-14 09:01:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502695394793430,
"parent_rev": "534488109de4a88e3fbd3f058a7220a46df55701", "commit_rev":
"1bcbdbe7292b842776463402c1b5e6db83bafb77"}

[commit-bot: I haz the power, 2017-08-14 09:02:01]

Description was changed from

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
V4L2ImageProcessor: Use VIDIOC_S_SELECTION for buffer region control

Applications have to use the selection API to work with v4l2 mem2mem
devices.
The old crop ioctls are not suitable for such hardware.
For backward compatibility we may fallback to use old crop APIs if the
codec driver doesn't support selection interfaces.

BUG=615857
TEST=Run VDA tests and play video on elm with fixed kernel driver
     for selection path.
     Run VEA tests and play video on peach_pi for fallback path.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2980793002
Cr-Commit-Position: refs/heads/master@{#494022}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bcbdbe7292b842776463402c1b5...
==========

[commit-bot: I haz the power, 2017-08-14 09:02:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1bcbdbe7292b842776463402c1b5...