Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2980773002: Revert of Deduplicate Monochrome locale .paks (Closed)

Created:
3 years, 5 months ago by F
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Deduplicate Monochrome locale .paks (patchset #4 id:180001 of https://codereview.chromium.org/2933343002/ ) Reason for revert: Chrome is now missing 5 locale strings. The reason is that these strings are believed to be in WebView locales because they're whitelisted, but since WebView uses multiple whitelists to pack its locale strings, these strings are actually not contained by WebView Original issue's description: > Deduplicate Monochrome locale .paks > > This CL removes WebView strings from Chrome locale .paks in Monochrome > using a generated resource whitelist. While WebView's locale resource > logic remains the same, Chrome in Monochrome now loads a secondary > locale pack file as a fallback when a string cannot be found in the > primary locale pack file. > > This CL reduces binary size by over 400KB. > > BUG=724110 > > Review-Url: https://codereview.chromium.org/2933343002 > Cr-Commit-Position: refs/heads/master@{#485635} > Committed: https://chromium.googlesource.com/chromium/src/+/08ba6b7c7e7edb3f7c8851eb7ddc1d2ea64497e6 TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724110, 741798 Review-Url: https://codereview.chromium.org/2980773002 Cr-Commit-Position: refs/heads/master@{#486397} Committed: https://chromium.googlesource.com/chromium/src/+/df9f33ffee10b4ffbd6469697bc916a137097860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -268 lines) Patch
M chrome/android/BUILD.gn View 4 chunks +6 lines, -50 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_paks.gni View 3 chunks +23 lines, -23 lines 0 comments Download
M chrome/common/descriptors_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/resources/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/resources/filter_resource_whitelist.py View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 5 chunks +13 lines, -40 lines 0 comments Download
M ui/base/resource/resource_bundle_android.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 6 chunks +24 lines, -69 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
F
Created Revert of Deduplicate Monochrome locale .paks
3 years, 5 months ago (2017-07-12 21:12:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980773002/1
3 years, 5 months ago (2017-07-12 21:14:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/427096)
3 years, 5 months ago (2017-07-12 22:49:11 UTC) #6
Dirk Pranke
lgtm
3 years, 5 months ago (2017-07-13 01:32:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980773002/1
3 years, 5 months ago (2017-07-13 15:15:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/df9f33ffee10b4ffbd6469697bc916a137097860
3 years, 5 months ago (2017-07-13 15:59:10 UTC) #12
F
3 years, 5 months ago (2017-07-14 18:26:05 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2977993002/ by zpeng@chromium.org.

The reason for reverting is: Will reland with fix.

Powered by Google App Engine
This is Rietveld 408576698