DescriptionRevert of Deduplicate Monochrome locale .paks (patchset #4 id:180001 of https://codereview.chromium.org/2933343002/ )
Reason for revert:
Chrome is now missing 5 locale strings. The reason is that these strings are believed to be in WebView locales because they're whitelisted, but since WebView uses multiple whitelists to pack its locale strings, these strings are actually not contained by WebView
Original issue's description:
> Deduplicate Monochrome locale .paks
>
> This CL removes WebView strings from Chrome locale .paks in Monochrome
> using a generated resource whitelist. While WebView's locale resource
> logic remains the same, Chrome in Monochrome now loads a secondary
> locale pack file as a fallback when a string cannot be found in the
> primary locale pack file.
>
> This CL reduces binary size by over 400KB.
>
> BUG=724110
>
> Review-Url: https://codereview.chromium.org/2933343002
> Cr-Commit-Position: refs/heads/master@{#485635}
> Committed: https://chromium.googlesource.com/chromium/src/+/08ba6b7c7e7edb3f7c8851eb7ddc1d2ea64497e6
TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=724110, 741798
Review-Url: https://codereview.chromium.org/2980773002
Cr-Commit-Position: refs/heads/master@{#486397}
Committed: https://chromium.googlesource.com/chromium/src/+/df9f33ffee10b4ffbd6469697bc916a137097860
Patch Set 1 #
Messages
Total messages: 13 (6 generated)
|