Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 2980733003: Introduced support for external services registration in the ServiceProtocol (Closed)
Patch Set: Address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_view.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart
index 716dc78240183362298c0eec45f88eb1ed9d17ed..edcc6e8041aa73f979b1cbf87210ab664cf1cbdd 100644
--- a/runtime/observatory/lib/src/elements/isolate_view.dart
+++ b/runtime/observatory/lib/src/elements/isolate_view.dart
@@ -22,6 +22,7 @@ import 'package:observatory/src/elements/nav/class_menu.dart';
import 'package:observatory/src/elements/nav/isolate_menu.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
+import 'package:observatory/src/elements/nav/reload.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/script_inset.dart';
@@ -43,6 +44,7 @@ class IsolateViewElement extends HtmlElement implements Renderable {
NavTopMenuElement.tag,
NavIsolateMenuElement.tag,
NavRefreshElement.tag,
+ NavReloadElement.tag,
NavNotifyElement.tag,
ScriptInsetElement.tag,
SourceInsetElement.tag,
@@ -140,10 +142,10 @@ class IsolateViewElement extends HtmlElement implements Renderable {
new NavTopMenuElement(queue: _r.queue),
new NavVMMenuElement(_vm, _events, queue: _r.queue),
new NavIsolateMenuElement(_isolate, _events, queue: _r.queue),
- new NavRefreshElement(label: 'Reload Source', queue: _r.queue)
- ..onRefresh.listen((e) async {
- e.element.disabled = true;
- await _isolates.reloadSources(_isolate);
+ new NavReloadElement(_isolate, _isolates, _events, queue: _r.queue)
+ ..onReload.listen((_) async {
+ _isolate = await _isolates.get(_isolate);
+ await _loadExtraData();
_r.dirty();
}),
new NavRefreshElement(queue: _r.queue)
« no previous file with comments | « runtime/observatory/lib/src/elements/helpers/nav_menu.dart ('k') | runtime/observatory/lib/src/elements/nav/reload.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698