runtime/observatory/lib/src/elements/helpers/nav_menu.dart - Issue 2980733003: Introduced support for external services registration in the ServiceProtocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/helpers/nav_menu.dart

Issue 2980733003: Introduced support for external services registration in the ServiceProtocol (Closed)

Patch Set: Address comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/helpers/nav_menu.dart

diff --git a/runtime/observatory/lib/src/elements/helpers/nav_menu.dart b/runtime/observatory/lib/src/elements/helpers/nav_menu.dart

index d1fd7919f62faf5555d05ce0f84ca4659501a8c0..a23f109c9e4d0b25b9a34203c7f82257b2c33493 100644

--- a/runtime/observatory/lib/src/elements/helpers/nav_menu.dart

+++ b/runtime/observatory/lib/src/elements/helpers/nav_menu.dart

@@ -4,10 +4,9 @@

import 'dart:html';

-navMenu(String label, {String link: '', Iterable<Element> content: const []}) {

+navMenu(String label, {String link, Iterable<Element> content: const []}) {

assert(label != null);

assert(content != null);

- assert(link != null);

return new LIElement()

..classes = ['nav-menu']

..children = [