Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2980683002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
davidben
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, vabr+watchlistlogin_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2980683002 Cr-Commit-Position: refs/heads/master@{#486278} Committed: https://chromium.googlesource.com/chromium/src/+/0a8995615b091ab5aed072b742d98eb441f41bb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/login/login_interstitial_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Łukasz Anforowicz
davidben@, can you PTAL?
3 years, 5 months ago (2017-07-13 00:04:20 UTC) #5
davidben
lgtm
3 years, 5 months ago (2017-07-13 02:15:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980683002/1
3 years, 5 months ago (2017-07-13 04:12:03 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 05:22:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a8995615b091ab5aed072b742d9...

Powered by Google App Engine
This is Rietveld 408576698