Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2980653003: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=sehr@chromium.org Review-Url: https://codereview.chromium.org/2980653003 Cr-Commit-Position: refs/heads/master@{#487605} Committed: https://chromium.googlesource.com/chromium/src/+/ab0cb861b3b6abef9d49d55fdf872a860e818aeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ppapi/native_client/tools/browser_tester/browserdata/nacltest.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Łukasz Anforowicz
sehr@, can you PTAL?
3 years, 5 months ago (2017-07-11 21:56:49 UTC) #3
sehr (please use chromium)
I no longer work on Pepper or NaCl. One of these two folks should be ...
3 years, 5 months ago (2017-07-18 20:21:32 UTC) #7
bbudge
lgtm
3 years, 5 months ago (2017-07-18 20:25:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980653003/1
3 years, 5 months ago (2017-07-18 20:26:44 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 21:07:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab0cb861b3b6abef9d49d55fdf87...

Powered by Google App Engine
This is Rietveld 408576698