Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2980603002: Print Preview: Return or crash on failures (Closed)

Created:
3 years, 5 months ago by rbpotter
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang, dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Return or crash on failures Ensure we always return after rejecting JS callback or CHECK if the condition should always be met. BUG=717296 Review-Url: https://codereview.chromium.org/2980603002 Cr-Commit-Position: refs/heads/master@{#485707} Committed: https://chromium.googlesource.com/chromium/src/+/cae285de3cfae6a0b24adefcdbb56d5b67b46739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rbpotter
3 years, 5 months ago (2017-07-11 16:34:08 UTC) #3
rbpotter
3 years, 5 months ago (2017-07-11 20:31:20 UTC) #8
dpapad
lgtm
3 years, 5 months ago (2017-07-11 21:19:09 UTC) #9
Lei Zhang
lgtm
3 years, 5 months ago (2017-07-11 21:23:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980603002/1
3 years, 5 months ago (2017-07-11 21:29:30 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 22:34:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cae285de3cfae6a0b24adefcdbb5...

Powered by Google App Engine
This is Rietveld 408576698