Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2980463002: Revert of [cr-action-menu] Use clientWidth for rtl flipping. (Closed)

Created:
3 years, 5 months ago by calamity
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [cr-action-menu] Use clientWidth for rtl flipping. (patchset #2 id:60001 of https://codereview.chromium.org/2966163004/ ) Reason for revert: Breaks on https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/15007 Original issue's description: > [cr-action-menu] Use clientWidth for rtl flipping. > > This CL fixes a bug where the action menu would use the entire body's > length as the viewport when flipping coordinates in RTL. > > It also moves the scroll position saving into showAtPosition so that > both show methods account for scroll correctly. > > BUG=734984 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2966163004 > Cr-Commit-Position: refs/heads/master@{#485181} > Committed: https://chromium.googlesource.com/chromium/src/+/87be8f4c1eaef26b7c6d7ddb2c56d84ef504a232 TBR=dpapad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=734984 Review-Url: https://codereview.chromium.org/2980463002 Cr-Commit-Position: refs/heads/master@{#485189} Committed: https://chromium.googlesource.com/chromium/src/+/1657a919ecc63f457d2c4049d58574fe2e7271d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -151 lines) Patch
M chrome/test/data/webui/cr_elements/cr_action_menu_test.js View 12 chunks +81 lines, -116 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js View 7 chunks +32 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
calamity
Created Revert of [cr-action-menu] Use clientWidth for rtl flipping.
3 years, 5 months ago (2017-07-10 05:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980463002/1
3 years, 5 months ago (2017-07-10 05:14:21 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 05:14:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1657a919ecc63f457d2c4049d585...

Powered by Google App Engine
This is Rietveld 408576698