[vr] Show DOFF when starting Chrome with a VR intent without FRE completion

chrome/android/java/AndroidManifest.xml

Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index 2c0c3b0150a36bc24845100495d49fa517e528ea..0fd2c6f68b4e114c33b2b660f88eff019b4172ae 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -422,6 +422,14 @@ by a child template that "extends" this file.
             android:windowSoftInputMode="stateHidden|adjustPan"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize">
         </activity>
+        <activity android:name="org.chromium.chrome.browser.vr_shell.VrFirstRunActivity"
+            android:exported="false"
+            android:theme="@style/VrActivityTheme"

[mthiesse, 2017/07/13 17:26:48]

You'll need to surround this android:theme and android:enableVrMode with {% if
enable_vr == "true" %} to prevent compile errors on x86/x64.

Actually, you might be able to surround the whole <activity> block here in {% if
enable_vr == "true" %}? I think it'll compile, and as long as you don't try to
start the VrFirstRunActivity it should be fine? Maybe dtrainor can confirm.

[ymalik, 2017/07/14 06:14:29]

Thanks for the tip! Surrounded the entire activity with {% if enable_vr ==
"true" %}. and made sure we only call the VrFirstRunActivity when VR is enabled.
I think* this should be fine but I'm not sure if this is the recommended way of
doing this. 

@dtrainor, thoughts? Should the conditional be for the vr specific attributes or
the entire activity?

+            android:excludeFromRecents="true"
+            android:enableVrMode="@string/gvr_vr_mode_component"
+            android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize|uiMode">
+            {{ self.supports_vr() }}
+        </activity>
         <activity android:name="org.chromium.chrome.browser.signin.AccountSigninActivity"
             android:theme="@style/DialogWhenLarge"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize">