[vr] Show DOFF when starting Chrome with a VR intent without FRE completion

chrome/android/java/AndroidManifest.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <!--
 Note: This is a jinja2 template, processed at build time into the final manifest.
 
 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden
 by a child template that "extends" this file.
@@ skipping 404 matching lines @@
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize">
         </activity>
         <activity android:name="org.chromium.chrome.browser.firstrun.FirstRunActivity"
             android:theme="@style/DialogWhenLarge"
             android:launchMode="singleInstance"
             android:excludeFromRecents="true"
             android:autoRemoveFromRecents="true"
             android:windowSoftInputMode="stateHidden|adjustPan"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize">
         </activity>
+        <activity android:name="org.chromium.chrome.browser.vr_shell.VrFirstRunActivity"
+            android:exported="false"
+            android:theme="@style/VrActivityTheme"

[mthiesse, 2017/07/13 17:26:48]

You'll need to surround this android:theme and android:enableVrMode with {% if
enable_vr == "true" %} to prevent compile errors on x86/x64.

Actually, you might be able to surround the whole <activity> block here in {% if
enable_vr == "true" %}? I think it'll compile, and as long as you don't try to
start the VrFirstRunActivity it should be fine? Maybe dtrainor can confirm.

[ymalik, 2017/07/14 06:14:29]

Thanks for the tip! Surrounded the entire activity with {% if enable_vr ==
"true" %}. and made sure we only call the VrFirstRunActivity when VR is enabled.
I think* this should be fine but I'm not sure if this is the recommended way of
doing this. 

@dtrainor, thoughts? Should the conditional be for the vr specific attributes or
the entire activity?

+            android:excludeFromRecents="true"
+            android:enableVrMode="@string/gvr_vr_mode_component"
+            android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize|uiMode">
+            {{ self.supports_vr() }}
+        </activity>
         <activity android:name="org.chromium.chrome.browser.signin.AccountSigninActivity"
             android:theme="@style/DialogWhenLarge"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize">
         </activity>
         <activity android:name="org.chromium.chrome.browser.preferences.Preferences"
             android:theme="@style/PreferencesTheme"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize"
             android:label="@string/preferences"
             android:exported="false">
         </activity>
@@ skipping 604 matching lines @@
              choose the first MediaRouteController that can play it, so the order of the list can be important.
              The most specific MediaRouteControllers should be listed first, followed by more generic ones.
              The downstream manifest replaces this block, and hence replaces the list of media route
              controllers with its own list. -->
         <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYERS"
             android:value="org.chromium.chrome.browser.media.remote.DefaultMediaRouteController"/>
 
         {% endblock %}
     </application>
 </manifest>