Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2980253002: Milo pubsub: Don't decode properties out of parameters (Closed)

Created:
3 years, 5 months ago by Ryan Tseng
Modified:
3 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo pubsub: Don't decode properties out of parameters This isn't used and also isn't always a string (could be an object) BUG=624960 Review-Url: https://codereview.chromium.org/2980253002 Committed: https://github.com/luci/luci-go/commit/33f9af6122fbc8938f1208ad0cbd35a2ffcc929b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M milo/buildsource/buildbucket/pubsub.go View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ryan Tseng
ptal
3 years, 5 months ago (2017-07-17 20:55:52 UTC) #5
iannucci
lgtm
3 years, 5 months ago (2017-07-17 21:42:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980253002/1
3 years, 5 months ago (2017-07-17 21:43:44 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 21:48:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/33f9af6122fbc8938f1208ad0cbd35a2ffcc929b

Powered by Google App Engine
This is Rietveld 408576698