Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2980233003: isolate: clean up some path handling (Closed)

Created:
3 years, 5 months ago by mcgreevy
Modified:
3 years, 5 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: clean up some path handling in directory walking code. BUG=692940 Review-Url: https://codereview.chromium.org/2980233003 Committed: https://github.com/luci/luci-go/commit/c73a01793deb23192570c36c44c1a3978d4eb0db

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M client/archiver/directory.go View 1 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mcgreevy
I'm splitting this out of a larger refactoring, to make it easier to review.
3 years, 5 months ago (2017-07-18 01:45:19 UTC) #2
mithro
LGTM. Nit: The subject / commit message could be better :-).
3 years, 5 months ago (2017-07-18 02:28:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980233003/20001
3 years, 5 months ago (2017-07-18 03:47:05 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 03:53:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/c73a01793deb23192570c36c44c1a3978d4eb0db

Powered by Google App Engine
This is Rietveld 408576698