chrome/browser/extensions/activity_log/activity_log_unittest.cc - Issue 298023009: Remove InstallTracker's extension load, unload observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_unittest.cc

Issue 298023009: Remove InstallTracker's extension load, unload observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and shutdown Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log.cc ('k') | chrome/browser/extensions/install_observer.h » ('j') | chrome/browser/ui/app_list/extension_app_model_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

index 1a4fcd1b0b5e8552b9c6b9ba6ca1e4a714cde5fb..5c2468a5c6fafc8d410b07d4d665476a01ad9668 100644

--- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

@@ -19,6 +19,7 @@

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/test/test_browser_thread_bundle.h"

+#include "extensions/browser/extension_registry.h"

#include "extensions/common/dom_action_types.h"

#include "extensions/common/extension_builder.h"

#include "sql/statement.h"

@@ -367,8 +368,7 @@ TEST_F(ActivityLogTest, UninstalledExtension) {

"document.write");

action->set_page_url(GURL("http://www.google.com"));

- activity_log->OnExtensionUninstalled(extension);

+ activity_log->OnExtensionUninstalled(NULL, extension);

activity_log->GetFilteredActions(

extension->id(),

Action::ACTION_ANY,