Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 298023009: Remove InstallTracker's extension load, unload observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and shutdown Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_model_builder.cc
diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc
index fdf191cc2126a305335d34c6273ab2ff1d51b1e3..95315ccd3b2b43cf1b6d485f694c9054b72c3e2f 100644
--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc
+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc
@@ -10,7 +10,6 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/command_line.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_ui_util.h"
#include "chrome/browser/extensions/install_tracker.h"
#include "chrome/browser/extensions/install_tracker_factory.h"
@@ -20,8 +19,8 @@
#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/ui/app_list/extension_app_item.h"
#include "chrome/common/chrome_switches.h"
-#include "content/public/browser/notification_service.h"
#include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/extensions_browser_client.h"
#include "extensions/browser/pref_names.h"
@@ -38,7 +37,8 @@ ExtensionAppModelBuilder::ExtensionAppModelBuilder(
controller_(controller),
model_(NULL),
highlighted_app_pending_(false),
- tracker_(NULL) {
+ tracker_(NULL),
+ extension_registry_observer_(this) {
}
ExtensionAppModelBuilder::~ExtensionAppModelBuilder() {
@@ -124,7 +124,9 @@ void ExtensionAppModelBuilder::OnInstallFailure(
model_->DeleteItem(extension_id);
}
-void ExtensionAppModelBuilder::OnExtensionLoaded(const Extension* extension) {
+void ExtensionAppModelBuilder::OnExtensionLoaded(
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension) {
if (!extensions::ui_util::ShouldDisplayInAppLauncher(extension, profile_))
return;
@@ -145,7 +147,10 @@ void ExtensionAppModelBuilder::OnExtensionLoaded(const Extension* extension) {
UpdateHighlight();
}
-void ExtensionAppModelBuilder::OnExtensionUnloaded(const Extension* extension) {
+void ExtensionAppModelBuilder::OnExtensionUnloaded(
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension,
+ extensions::UnloadedExtensionInfo::Reason reason) {
ExtensionAppItem* item = GetExtensionAppItem(extension->id());
if (!item)
return;
@@ -153,7 +158,8 @@ void ExtensionAppModelBuilder::OnExtensionUnloaded(const Extension* extension) {
}
void ExtensionAppModelBuilder::OnExtensionUninstalled(
- const Extension* extension) {
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension) {
if (service_) {
DVLOG(2) << service_ << ": OnExtensionUninstalled: "
<< extension->id().substr(0, 8);
@@ -210,6 +216,9 @@ void ExtensionAppModelBuilder::BuildModel() {
// Start observing after model is built.
if (tracker_)
tracker_->AddObserver(this);
+
+ extension_registry_observer_.Add(
+ extensions::ExtensionRegistry::Get(profile_));
}
void ExtensionAppModelBuilder::PopulateApps() {

Powered by Google App Engine
This is Rietveld 408576698