Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2980133002: Move null check out of getExtensionType (Closed)

Created:
3 years, 5 months ago by Leaf
Modified:
3 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 5 months ago (2017-07-14 23:08:15 UTC) #2
Jennifer Messerly
lgtm!
3 years, 5 months ago (2017-07-14 23:42:13 UTC) #3
Leaf
3 years, 5 months ago (2017-07-15 00:02:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f059e58b4bd8962723566a5600dc9772483466c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698