Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

Issue 2980133002: Move null check out of getExtensionType (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart
index 384df2d80cabfabaa0f24ecc15222ce568b17389..521716bdf06a9820bdcfe7f0d26c0d3220f61c94 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart
@@ -125,6 +125,7 @@ getReifiedType(obj) {
return _nonPrimitiveRuntimeType(obj);
}
+/// Assumes that obj is non-null
_nonPrimitiveRuntimeType(obj) {
// Lookup recorded *real* type (not user definable runtimeType)
// TODO(vsm): Should we treat Dart and JS objects differently here?
@@ -163,6 +164,7 @@ Type wrapType(type) {
/// Given a WrappedType, return the internal runtime type object.
unwrapType(WrappedType obj) => obj._wrappedType;
+/// Assumes that value is non-null
_getRuntimeType(value) => JS('', '#[#]', value, _runtimeType);
/// Return the module name for a raw library object.
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698