[tracing] Add trace events to key heap profiler functions.

[tracing] Add trace events to key heap profiler functions.

This CL adds TRACE_EVENTs to several heap profiler-related functions
to surface their timings.

BUG=739378
Review-Url: https://codereview.chromium.org/2980083002
Cr-Commit-Position: refs/heads/master@{#486874}
Committed: https://chromium.googlesource.com/chromium/src/+/4136d111362c226d05204abb711b45bdaed48852

[DmitrySkiba, 2017-07-14 13:38:46]

dskiba@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-07-14 14:45:04]

lgtm with minor comments

https://codereview.chromium.org/2980083002/diff/1/base/trace_event/trace_log.cc
File base/trace_event/trace_log.cc (right):

https://codereview.chromium.org/2980083002/diff/1/base/trace_event/trace_log....
base/trace_event/trace_log.cc:884:
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("memory-infra"),
Hmm I am not sure about this one. In all honesty having TRACE_EVENT macros
within TraceLog itself makes me a bit worried.  can you remove this?

[DmitrySkiba, 2017-07-14 16:58:02]

On 2017/07/14 14:45:04, Primiano Tucci wrote:
> lgtm with minor comments
> 
>
https://codereview.chromium.org/2980083002/diff/1/base/trace_event/trace_log.cc
> File base/trace_event/trace_log.cc (right):
> 
>
https://codereview.chromium.org/2980083002/diff/1/base/trace_event/trace_log....
> base/trace_event/trace_log.cc:884:
> TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("memory-infra"),
> Hmm I am not sure about this one. In all honesty having TRACE_EVENT macros
> within TraceLog itself makes me a bit worried.  can you remove this?

Yup, you are right, it's useless to add trace events in a function that
serializes trace events :)

[DmitrySkiba, 2017-07-14 16:58:39]

The CQ bit was checked by dskiba@chromium.org

[DmitrySkiba, 2017-07-14 16:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2980083002/#ps20001
(title: "Don't trace in TraceLog")

[commit-bot: I haz the power, 2017-07-14 16:58:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 18:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 18:42:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[DmitrySkiba, 2017-07-14 19:57:17]

The CQ bit was checked by dskiba@chromium.org

[commit-bot: I haz the power, 2017-07-14 19:57:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 20:38:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500062237993360,
"parent_rev": "c861f7b398c4e1587784713893c900565bba0f06", "commit_rev":
"b6ded3afc48f91b425378940e3d800da25b144ef"}

[commit-bot: I haz the power, 2017-07-14 20:38:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500062237993360,
"parent_rev": "45af4ef1ce3a6345401c298631a8dc9215efa7a2", "commit_rev":
"4136d111362c226d05204abb711b45bdaed48852"}

[commit-bot: I haz the power, 2017-07-14 20:39:04]

Description was changed from

==========
[tracing] Add trace events to key heap profiler functions.

This CL adds TRACE_EVENTs to several heap profiler-related functions
to surface their timings.

BUG=739378
==========

to

==========
[tracing] Add trace events to key heap profiler functions.

This CL adds TRACE_EVENTs to several heap profiler-related functions
to surface their timings.

BUG=739378

Review-Url: https://codereview.chromium.org/2980083002
Cr-Commit-Position: refs/heads/master@{#486874}
Committed:
https://chromium.googlesource.com/chromium/src/+/4136d111362c226d05204abb711b...
==========

[commit-bot: I haz the power, 2017-07-14 20:39:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4136d111362c226d05204abb711b...