Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: pkg/compiler/lib/src/inferrer/inferrer_engine.dart

Issue 2980073002: Remove unneeded methods from InferrerEngine. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/locals_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/inferrer_engine.dart
diff --git a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
index 0f7d85cda5714dad727e470aab55b16a3e891d34..1a2c85d81fb40486b750c41dad2f095ac286581e 100644
--- a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
+++ b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
@@ -132,24 +132,8 @@ abstract class InferrerEngine {
void recordReturnType(MethodElement element, TypeInformation type);
/// Records that [element] is of type [type].
- // TODO(johnniwinther): Merge [recordTypeOfFinalField] and
- // [recordTypeOfNonFinalField] with this?
void recordTypeOfField(FieldElement element, TypeInformation type);
- /// Records that [node] sets final field [element] to be of type [type].
- void recordTypeOfFinalField(FieldElement element, TypeInformation type);
-
- /// Records that [node] sets non-final field [element] to be of type [type].
- void recordTypeOfNonFinalField(FieldElement element, TypeInformation type);
-
- /// Records that the captured variable [local] is read.
- // TODO(johnniwinther): Remove this.
- void recordCapturedLocalRead(Local local) {}
-
- /// Records that the variable [local] is being updated.
- // TODO(johnniwinther): Remove this.
- void recordLocalUpdate(Local local, TypeInformation type) {}
-
/// Registers a call to await with an expression of type [argumentType] as
/// argument.
TypeInformation registerAwait(ast.Node node, TypeInformation argument);
@@ -721,10 +705,10 @@ class InferrerEngineImpl extends InferrerEngine {
// Only update types of static fields if there is no
// assignment. Instance fields are dealt with in the constructor.
if (Elements.isStaticOrTopLevelField(element)) {
- recordTypeOfNonFinalField(element, type);
+ recordTypeOfField(element, type);
}
} else {
- recordTypeOfNonFinalField(element, type);
+ recordTypeOfField(element, type);
}
if (Elements.isStaticOrTopLevelField(element) &&
resolvedAst.body != null &&
@@ -923,14 +907,6 @@ class InferrerEngineImpl extends InferrerEngine {
return types.getInferredTypeOfMember(element);
}
- void recordTypeOfFinalField(FieldElement element, TypeInformation type) {
- types.getInferredTypeOfMember(element).addAssignment(type);
- }
-
- void recordTypeOfNonFinalField(FieldElement element, TypeInformation type) {
- types.getInferredTypeOfMember(element).addAssignment(type);
- }
-
void recordTypeOfField(FieldElement element, TypeInformation type) {
types.getInferredTypeOfMember(element).addAssignment(type);
}
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/locals_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698