Remove unneeded methods from InferrerEngine.

pkg/compiler/lib/src/inferrer/inferrer_engine.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../common.dart';
 import '../common/names.dart';
 import '../compiler.dart';
 import '../constants/expressions.dart';
@@ skipping 114 matching lines @@
   GlobalTypeInferenceElementData lookupDataOfMember(MemberElement element);
 
   bool checkIfExposesThis(ConstructorElement element);
 
   void recordExposesThis(ConstructorElement element, bool exposesThis);
 
   /// Records that the return type [element] is of type [type].
   void recordReturnType(MethodElement element, TypeInformation type);
 
   /// Records that [element] is of type [type].
-  // TODO(johnniwinther): Merge [recordTypeOfFinalField] and
-  // [recordTypeOfNonFinalField] with this?
   void recordTypeOfField(FieldElement element, TypeInformation type);
 
-  /// Records that [node] sets final field [element] to be of type [type].
-  void recordTypeOfFinalField(FieldElement element, TypeInformation type);
-
-  /// Records that [node] sets non-final field [element] to be of type [type].
-  void recordTypeOfNonFinalField(FieldElement element, TypeInformation type);
-
-  /// Records that the captured variable [local] is read.
-  // TODO(johnniwinther): Remove this.
-  void recordCapturedLocalRead(Local local) {}
-
-  /// Records that the variable [local] is being updated.
-  // TODO(johnniwinther): Remove this.
-  void recordLocalUpdate(Local local, TypeInformation type) {}
-
   /// Registers a call to await with an expression of type [argumentType] as
   /// argument.
   TypeInformation registerAwait(ast.Node node, TypeInformation argument);
 
   /// Registers a call to yield with an expression of type [argumentType] as
   /// argument.
   TypeInformation registerYield(ast.Node node, TypeInformation argument);
 
   /// Registers that [caller] calls [closure] with [arguments].
   ///
@@ skipping 551 matching lines @@
             }
           }
           recordTypeOfField(element, type);
         } else if (!element.isInstanceMember) {
           recordTypeOfField(element, types.nullType);
         }
       } else if (initializer == null) {
         // Only update types of static fields if there is no
         // assignment. Instance fields are dealt with in the constructor.
         if (Elements.isStaticOrTopLevelField(element)) {
-          recordTypeOfNonFinalField(element, type);
+          recordTypeOfField(element, type);
         }
       } else {
-        recordTypeOfNonFinalField(element, type);
+        recordTypeOfField(element, type);
       }
       if (Elements.isStaticOrTopLevelField(element) &&
           resolvedAst.body != null &&
           !element.isConst) {
         dynamic argument = resolvedAst.body;
         // TODO(13429): We could do better here by using the
         // constant handler to figure out if it's a lazy field or not.
         if (argument.asSend() != null ||
             (argument.asNewExpression() != null && !argument.isConst)) {
           recordTypeOfField(element, types.nullType);
@@ skipping 178 matching lines @@
   TypeInformation typeOfMember(MemberElement element) {
     if (element is MethodElement) return types.functionType;
     return types.getInferredTypeOfMember(element);
   }
 
   TypeInformation returnTypeOfMember(MemberElement element) {
     if (element is! MethodElement) return types.dynamicType;
     return types.getInferredTypeOfMember(element);
   }
 
-  void recordTypeOfFinalField(FieldElement element, TypeInformation type) {
-    types.getInferredTypeOfMember(element).addAssignment(type);
-  }
-
-  void recordTypeOfNonFinalField(FieldElement element, TypeInformation type) {
-    types.getInferredTypeOfMember(element).addAssignment(type);
-  }
-
   void recordTypeOfField(FieldElement element, TypeInformation type) {
     types.getInferredTypeOfMember(element).addAssignment(type);
   }
 
   void recordReturnType(MethodElement element, TypeInformation type) {
     TypeInformation info = types.getInferredTypeOfMember(element);
     if (element.name == '==') {
       // Even if x.== doesn't return a bool, 'x == null' evaluates to 'false'.
       info.addAssignment(types.boolType);
     }
@@ skipping 323 matching lines @@
   @override
   bool checkPhiNode(ast.Node node) {
     return true;
   }
 
   @override
   bool checkClassEntity(covariant ClassElement cls) {
     return cls.isDeclaration;
   }
 }