Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2980063002: DevTools: allow colorpicker to scroll horizontally (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow colorpicker to scroll horizontally http://imgur.com/a/M8GzH BUG=733126, 739615 Review-Url: https://codereview.chromium.org/2980063002 Cr-Commit-Position: refs/heads/master@{#487775} Committed: https://chromium.googlesource.com/chromium/src/+/3fb3c93697045d0406c201713eeb6da8be594860

Patch Set 1 #

Patch Set 2 : DevTools: allow colorpicker to scroll horizontally #

Patch Set 3 : no important #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js View 1 2 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (5 generated)
luoe
Please take a look
3 years, 5 months ago (2017-07-14 01:35:42 UTC) #2
luoe
https://codereview.chromium.org/2980063002/diff/40001/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js File third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js (right): https://codereview.chromium.org/2980063002/diff/40001/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js#newcode118 third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js:118: this.element.classList.add('palettes-enabled', 'flex-none'); This component has a shadowRoot, and adding ...
3 years, 5 months ago (2017-07-18 20:49:08 UTC) #4
lushnikov
lgtm
3 years, 5 months ago (2017-07-19 03:05:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980063002/40001
3 years, 5 months ago (2017-07-19 04:59:15 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 07:05:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3fb3c93697045d0406c201713eeb...

Powered by Google App Engine
This is Rietveld 408576698