Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2980033002: Moves the top_ and end_ words of the Scavenger into mutator thread. (Closed)

Created:
3 years, 5 months ago by danunez
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moves the top_ and end_ words of the Scavenger into mutator thread. This is the first step to adding Thread Local Allocation Buffers to the VM. In this step, the mutator alone allocates to the new space, but keeps track of the start and end of the space. This is akin to a single large TLAB. As a result, the generated code and the dbc simulator changed how they allocate objects into the new space as well. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/699f84f94141e405330ab1bd15dc7b58ba3067df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -234 lines) Patch
M runtime/vm/assembler_arm.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/heap.h View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/heap.cc View 3 chunks +7 lines, -20 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.h View 4 chunks +39 lines, -18 lines 0 comments Download
M runtime/vm/scavenger.cc View 9 chunks +37 lines, -2 lines 0 comments Download
M runtime/vm/scavenger_test.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 5 chunks +12 lines, -18 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 6 chunks +12 lines, -21 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 4 chunks +12 lines, -17 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 5 chunks +12 lines, -19 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danunez
Fixes what broke the DBC simulator in the last CL.
3 years, 5 months ago (2017-07-13 19:45:55 UTC) #1
rmacnak
lgtm
3 years, 5 months ago (2017-07-13 20:44:58 UTC) #2
danunez
3 years, 5 months ago (2017-07-13 20:46:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
699f84f94141e405330ab1bd15dc7b58ba3067df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698