Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: runtime/vm/isolate.cc

Issue 2980033002: Moves the top_ and end_ words of the Scavenger into mutator thread. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 2d8bb4bfb638e2538f48d17e92a99fb18f81e5b6..7abc24875e8326b68c05ac17eb201afa40e21d7f 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -2554,6 +2554,10 @@ Thread* Isolate::ScheduleThread(bool is_mutator, bool bypass_safepoint) {
os_thread->set_thread(thread);
if (is_mutator) {
mutator_thread_ = thread;
+ if (this != Dart::vm_isolate()) {
+ mutator_thread_->set_top(heap()->new_space()->top());
+ mutator_thread_->set_end(heap()->new_space()->end());
+ }
}
Thread::SetCurrent(thread);
os_thread->EnableThreadInterrupts();
@@ -2592,6 +2596,12 @@ void Isolate::UnscheduleThread(Thread* thread,
os_thread->set_thread(NULL);
OSThread::SetCurrent(os_thread);
if (is_mutator) {
+ if (this != Dart::vm_isolate()) {
+ heap()->new_space()->set_top(mutator_thread_->top_);
+ heap()->new_space()->set_end(mutator_thread_->end_);
+ }
+ mutator_thread_->top_ = 0;
+ mutator_thread_->end_ = 0;
mutator_thread_ = NULL;
}
thread->isolate_ = NULL;
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698