Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298003008: Shell / ShellClient -> ServiceProvider (Closed)

Created:
6 years, 7 months ago by DaveMoore
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Shell / ShellClient -> ServiceProvider Try #2 of https://codereview.chromium.org/298653010/ Fixed newly introduced GN dependency. TBR=darin@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -666 lines) Patch
M content/browser/mojo/mojo_application_host.h View 2 chunks +11 lines, -9 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_thread.h View 3 chunks +6 lines, -5 lines 0 comments Download
M content/child/child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/mojo/mojo_application.h View 2 chunks +7 lines, -5 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/main.js View 5 chunks +10 lines, -7 lines 0 comments Download
M mojo/dbus/dbus_external_service.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/dbus/dbus_external_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/dbus_echo/dbus_echo_app.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/mojo.gyp View 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/mojo_examples.gypi View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +10 lines, -10 lines 0 comments Download
M mojo/mojo_services.gypi View 5 chunks +5 lines, -5 lines 0 comments Download
A + mojo/public/cpp/application/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/application/application.h View 5 chunks +15 lines, -14 lines 0 comments Download
A mojo/public/cpp/application/connect.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + mojo/public/cpp/application/lib/application.cc View 2 chunks +9 lines, -8 lines 0 comments Download
A + mojo/public/cpp/application/lib/service_connector.h View 5 chunks +11 lines, -11 lines 0 comments Download
A + mojo/public/cpp/application/lib/service_connector.cc View 1 chunk +5 lines, -4 lines 0 comments Download
D mojo/public/cpp/shell/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/cpp/shell/application.h View 1 chunk +0 lines, -93 lines 0 comments Download
D mojo/public/cpp/shell/connect.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/cpp/shell/lib/application.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/public/cpp/shell/lib/service_connector.h View 1 chunk +0 lines, -141 lines 0 comments Download
D mojo/public/cpp/shell/lib/service_connector.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A + mojo/public/interfaces/service_provider/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/interfaces/service_provider/service_provider.mojom View 1 chunk +3 lines, -7 lines 0 comments Download
D mojo/public/interfaces/shell/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/interfaces/shell/shell.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
M mojo/service_manager/background_service_loader.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/service_manager/background_service_loader.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/service_manager/service_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_manager.h View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/service_manager/service_manager.cc View 5 chunks +22 lines, -20 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/main.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M mojo/shell/android/mojo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dbus_service_loader_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/dbus_service_loader_linux.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/dynamic_service_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/dynamic_service_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/external_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/run.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_test_helper.h View 4 chunks +13 lines, -11 lines 0 comments Download
M mojo/shell/shell_test_helper.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M mojo/shell/view_manager_loader.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/view_manager_loader.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
DaveMoore
6 years, 7 months ago (2014-05-27 16:50:36 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r272989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698