Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: mojo/shell/dbus_service_loader_linux.cc

Issue 298003008: Shell / ShellClient -> ServiceProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/dbus_service_loader_linux.h ('k') | mojo/shell/dynamic_service_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/dbus_service_loader_linux.cc
diff --git a/mojo/shell/dbus_service_loader_linux.cc b/mojo/shell/dbus_service_loader_linux.cc
index f2ecbcf26a6c6ce0e0bb69bbced0bb8d4f32fb3d..99cf1a9d3b10bfb9a7a52e989853dd6673678c6c 100644
--- a/mojo/shell/dbus_service_loader_linux.cc
+++ b/mojo/shell/dbus_service_loader_linux.cc
@@ -37,12 +37,12 @@ class DBusServiceLoader::LoadContext {
LoadContext(DBusServiceLoader* loader,
const scoped_refptr<dbus::Bus>& bus,
const GURL& url,
- ScopedMessagePipeHandle shell_handle)
+ ScopedMessagePipeHandle service_provider_handle)
: loader_(loader),
bus_(bus),
service_dbus_proxy_(NULL),
url_(url),
- shell_handle_(shell_handle.Pass()),
+ service_provider_handle_(service_provider_handle.Pass()),
keep_alive_(loader->context_) {
base::PostTaskAndReplyWithResult(
loader_->context_->task_runners()->io_runner(),
@@ -108,7 +108,8 @@ class DBusServiceLoader::LoadContext {
mojo::AllocationScope scope;
external_service_->Activate(
mojo::ScopedMessagePipeHandle(
- mojo::MessagePipeHandle(shell_handle_.release().value())));
+ mojo::MessagePipeHandle(
+ service_provider_handle_.release().value())));
}
// Should the ExternalService disappear completely, destroy connection state.
@@ -132,7 +133,7 @@ class DBusServiceLoader::LoadContext {
scoped_refptr<dbus::Bus> bus_;
dbus::ObjectProxy* service_dbus_proxy_; // Owned by bus_;
const GURL url_;
- ScopedMessagePipeHandle shell_handle_;
+ ScopedMessagePipeHandle service_provider_handle_;
KeepAlive keep_alive_;
scoped_ptr<common::ChannelInit> channel_init_;
ExternalServicePtr external_service_;
« no previous file with comments | « mojo/shell/dbus_service_loader_linux.h ('k') | mojo/shell/dynamic_service_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698