Issue 298001: Correcting dependency problem that causes setup.exe to get built before chrom...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298001: Correcting dependency problem that causes setup.exe to get built before chrom... (Closed)

Created:
11 years, 2 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
slightlyoff

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Correcting dependency problem that causes setup.exe to get built before chrome frame - this results in chrome frame not getting registered when setup is run. BUG=http://crbug.com/25074 TEST=When Chrome Frame is built, the resulting mini_installer registers Chrome Frame. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29384

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	chrome/installer/installer.gyp	View		1 chunk	+12 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages