Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/installer/installer.gyp

Issue 298001: Correcting dependency problem that causes setup.exe to get built before chrom... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'version_py': '../../chrome/tools/build/version.py', 3 'version_py': '../../chrome/tools/build/version.py',
4 'version_path': '../../chrome/VERSION', 4 'version_path': '../../chrome/VERSION',
5 'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE', 5 'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
6 # 'branding_dir' is set in the 'conditions' section at the bottom. 6 # 'branding_dir' is set in the 'conditions' section at the bottom.
7 }, 7 },
8 'conditions': [ 8 'conditions': [
9 ['OS=="win"', { 9 ['OS=="win"', {
10 'targets': [ 10 'targets': [
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 '<(scan_server_dlls_py)', 326 '<(scan_server_dlls_py)',
327 '--output_dir=<(PRODUCT_DIR)', 327 '--output_dir=<(PRODUCT_DIR)',
328 '--input_file=<(RULE_INPUT_PATH)', 328 '--input_file=<(RULE_INPUT_PATH)',
329 '--header_output_dir=<(INTERMEDIATE_DIR)', 329 '--header_output_dir=<(INTERMEDIATE_DIR)',
330 # TODO(sgk): may just use environment variables 330 # TODO(sgk): may just use environment variables
331 #'--distribution=$(CHROMIUM_BUILD)', 331 #'--distribution=$(CHROMIUM_BUILD)',
332 '--distribution=_google_chrome', 332 '--distribution=_google_chrome',
333 ], 333 ],
334 }, 334 },
335 ], 335 ],
336 # TODO(mark): <(branding_dir) should be defined by the
337 # global condition block at the bottom of the file, but
338 # this doesn't work due to the following issue:
339 #
340 # http://code.google.com/p/gyp/issues/detail?id=22
341 #
342 # Remove this block once the above issue is fixed.
343 'conditions': [ 336 'conditions': [
337 ['chrome_frame_define==1', {
338 'dependencies': [
339 '../../chrome_frame/chrome_frame.gyp:npchrome_tab',
340 ],
341 }],
342 # TODO(mark): <(branding_dir) should be defined by the
343 # global condition block at the bottom of the file, but
344 # this doesn't work due to the following issue:
345 #
346 # http://code.google.com/p/gyp/issues/detail?id=22
347 #
348 # Remove this block once the above issue is fixed.
344 [ 'branding == "Chrome"', { 349 [ 'branding == "Chrome"', {
345 'variables': { 350 'variables': {
346 'branding_dir': '../app/theme/google_chrome', 351 'branding_dir': '../app/theme/google_chrome',
347 }, 352 },
348 }, { # else branding!="Chrome" 353 }, { # else branding!="Chrome"
349 'variables': { 354 'variables': {
350 'branding_dir': '../app/theme/chromium', 355 'branding_dir': '../app/theme/chromium',
351 }, 356 },
352 }], 357 }],
353 ], 358 ],
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 }, 629 },
625 }], 630 }],
626 ], 631 ],
627 } 632 }
628 633
629 # Local Variables: 634 # Local Variables:
630 # tab-width:2 635 # tab-width:2
631 # indent-tabs-mode:nil 636 # indent-tabs-mode:nil
632 # End: 637 # End:
633 # vim: set expandtab tabstop=2 shiftwidth=2: 638 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698