Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2979923002:
ChromeOS: add support for Gaia v2 API. (Closed)
|
Created:
3 years, 5 months ago by Alexander Alekseev Modified:
3 years, 5 months ago Reviewers:
achuithb CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionChromeOS: add support for Gaia v2 API.
This CL adds support for Gaia v2 API to oobe.py
BUG=chromium:739998
Review-Url: https://codereview.chromium.org/2979923002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dac0038997b8387868c9e30268bb786d1676c1c9
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed useless check and expanded a comment. #
Total comments: 4
Patch Set 3 : Update after review. #Messages
Total messages: 18 (11 generated)
alemate@chromium.org changed reviewers: + achuith@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2979923002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/backends/chrome/oobe.py (right): https://codereview.chromium.org/2979923002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/backends/chrome/oobe.py:120: field = field.getElementsByTagName('INPUT')[0]; What's going on here? Should we just use getElementsByTagName('INPUT') for both v1 and v2 instead of bothering with getElementById? We could drop the 'field' input param to this function in that case. Maybe we can also drop next_field and use getElementsByTagName there too?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2979923002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/backends/chrome/oobe.py (right): https://codereview.chromium.org/2979923002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/backends/chrome/oobe.py:120: field = field.getElementsByTagName('INPUT')[0]; On 2017/07/13 01:03:32, achuithb wrote: > What's going on here? > > Should we just use getElementsByTagName('INPUT') for both v1 and v2 instead of > bothering with getElementById? We could drop the 'field' input param to this > function in that case. > > Maybe we can also drop next_field and use getElementsByTagName there too? Updated per offline discussion.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. Thanks! https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... File telemetry/telemetry/internal/backends/chrome/oobe.py (right): https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... telemetry/telemetry/internal/backends/chrome/oobe.py:117: # In v2 'password' id is assigned to <DIV> element encapculating sp encapsulating https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... telemetry/telemetry/internal/backends/chrome/oobe.py:123: if (field.tagName != 'INPUT') { Drop {}
https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... File telemetry/telemetry/internal/backends/chrome/oobe.py (right): https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... telemetry/telemetry/internal/backends/chrome/oobe.py:117: # In v2 'password' id is assigned to <DIV> element encapculating On 2017/07/13 01:45:39, achuithb wrote: > sp encapsulating Done. https://codereview.chromium.org/2979923002/diff/20001/telemetry/telemetry/int... telemetry/telemetry/internal/backends/chrome/oobe.py:123: if (field.tagName != 'INPUT') { On 2017/07/13 01:45:39, achuithb wrote: > Drop {} Done.
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2979923002/#ps40001 (title: "Update after review.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499911095016340,
"parent_rev": "e4d806cd4821f1e82d11d9ca1b1e1f500e503c11", "commit_rev":
"dac0038997b8387868c9e30268bb786d1676c1c9"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: add support for Gaia v2 API. This CL adds support for Gaia v2 API to oobe.py BUG=chromium:739998 ========== to ========== ChromeOS: add support for Gaia v2 API. This CL adds support for Gaia v2 API to oobe.py BUG=chromium:739998 Review-Url: https://codereview.chromium.org/2979923002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
