Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2979903003: [CUPS] If no printers is auto-discovered, show the manual printer setup dialog (Closed)

Created:
3 years, 5 months ago by xdai1
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] If there is no auto-discovered printer, show the manual printer setup dialog. When setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery. However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers. BUG=735244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979903003 Cr-Commit-Position: refs/heads/master@{#486811} Committed: https://chromium.googlesource.com/chromium/src/+/007abfb715a7f00fb9d2d301626b5271940ad246

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 4 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
3 years, 5 months ago (2017-07-13 18:38:00 UTC) #7
michaelpg
lgtm
3 years, 5 months ago (2017-07-13 20:04:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979903003/20001
3 years, 5 months ago (2017-07-14 18:04:04 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 18:16:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/007abfb715a7f00fb9d2d301626b...

Powered by Google App Engine
This is Rietveld 408576698