Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2979743002: Print Preview: Remove system dialog link container on ChromeOS (Closed)

Created:
3 years, 5 months ago by rbpotter
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Remove system dialog link container on ChromeOS Should not add the link-container on ChromeOS as the system dialog link will never be shown. BUG=731578 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979743002 Cr-Commit-Position: refs/heads/master@{#485794} Committed: https://chromium.googlesource.com/chromium/src/+/58eaa08bb7b92a9c3b9a826fc4126e1660286e8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
rbpotter
3 years, 5 months ago (2017-07-11 18:36:16 UTC) #5
dpapad
LGTM
3 years, 5 months ago (2017-07-11 19:10:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979743002/1
3 years, 5 months ago (2017-07-12 01:17:20 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 02:06:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58eaa08bb7b92a9c3b9a826fc412...

Powered by Google App Engine
This is Rietveld 408576698